Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security(platform/backend): Add health endpoint #8341

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

aarushik93
Copy link
Contributor

Background

Add health endpoint to use instead of docs

Changes πŸ—οΈ

Added a health endpoint to rest api

Testing πŸ”

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

@aarushik93 aarushik93 requested review from a team as code owners October 15, 2024 11:48
@aarushik93 aarushik93 requested review from Torantulino and Bentlybro and removed request for a team October 15, 2024 11:48
@github-actions github-actions bot added documentation Improvements or additions to documentation platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end size/l labels Oct 15, 2024
Copy link

PR Reviewer Guide πŸ”

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 πŸ”΅πŸ”΅πŸ”΅πŸ”΅βšͺ
πŸ§ͺΒ No relevant tests
πŸ”’Β No security concerns identified
⚑ Recommended focus areas for review

New Abstract Method
A new abstract method revoke_tokens has been added to the BaseOAuthHandler class. Ensure all subclasses implement this method correctly.

API Change
The delete_credentials endpoint now returns a CredentialsDeletionResponse instead of a 204 status code. Ensure this change is reflected in the API documentation and client implementations.

New Functionality
A new deleteCredentials function has been added to handle credential deletion and update the UI accordingly. Ensure it's properly integrated with the rest of the application.

@aarushik93 aarushik93 changed the base branch from master to dev October 15, 2024 11:49
Copy link

netlify bot commented Oct 15, 2024

βœ… Deploy Preview for auto-gpt-docs ready!

Name Link
πŸ”¨ Latest commit b71db62
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/670e56982e582c0008e52fb7
😎 Deploy Preview https://deploy-preview-8341--auto-gpt-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 49.62%. Comparing base (a2ef456) to head (b71db62).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #8341   +/-   ##
=======================================
  Coverage   49.62%   49.62%           
=======================================
  Files         144      144           
  Lines        8916     8916           
  Branches     1240     1240           
=======================================
  Hits         4425     4425           
  Misses       4344     4344           
  Partials      147      147           
Flag Coverage Ξ”
Linux 49.43% <ΓΈ> (ΓΈ)
Windows 50.03% <ΓΈ> (ΓΈ)
agbenchmark 34.07% <ΓΈ> (ΓΈ)
autogpt-agent 33.94% <ΓΈ> (ΓΈ)
forge 58.03% <ΓΈ> (ΓΈ)
macOS 48.90% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

ntindle
ntindle previously approved these changes Oct 15, 2024
@ntindle
Copy link
Member

ntindle commented Oct 15, 2024

Fix linting but code is good. Now that we have this, it may be a good place to add other info for the bot to ping like version etc cc @Bentlybro

@github-actions github-actions bot added size/m and removed documentation Improvements or additions to documentation platform/frontend AutoGPT Platform - Front end size/l labels Oct 15, 2024
Swiftyos
Swiftyos previously approved these changes Oct 16, 2024
Copy link
Contributor

@Swiftyos Swiftyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to fix the linting errors

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Oct 16, 2024
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved! πŸŽ‰ A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Oct 16, 2024
ntindle
ntindle previously approved these changes Oct 16, 2024
@aarushik93 aarushik93 enabled auto-merge (squash) October 16, 2024 14:55
@aarushik93 aarushik93 merged commit 2d0e51f into dev Oct 16, 2024
7 checks passed
@aarushik93 aarushik93 deleted the aarushikansal/add-new-health-endpoint branch October 16, 2024 14:57
aarushik93 added a commit that referenced this pull request Oct 16, 2024
* add health endpoint

* fix linting

---------

Co-authored-by: Nicholas Tindle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: βœ… Done
Development

Successfully merging this pull request may close these issues.

3 participants