Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove export from dev command #8149

Closed
wants to merge 1 commit into from
Closed

Remove export from dev command #8149

wants to merge 1 commit into from

Conversation

ntindle
Copy link
Member

@ntindle ntindle commented Sep 24, 2024

Background

Windows doesn’t support export commands. The only place this is used is sentry which Craig has a PR for disabling the popup

Changes 🏗️

removes the environment variable from dev

Testing 🔍

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

@ntindle ntindle requested a review from a team as a code owner September 24, 2024 15:30
@ntindle ntindle requested review from Swiftyos and Pwuts and removed request for a team September 24, 2024 15:30
@github-actions github-actions bot added the platform/frontend AutoGPT Platform - Front end label Sep 24, 2024
Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Key issues to review

Environment Variable
The NODE_ENV environment variable is no longer set for the 'dev' script, which may affect development environment behavior.

Inconsistent Syntax
The 'dev:test' script uses a different syntax for setting NODE_ENV compared to the removed 'export' command, which may not work as expected on all platforms.

Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 641c027
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/66f2db08318b21000877e766

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant