Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak(platform): Update block descriptions and tweak block card ui #8147

Merged
merged 7 commits into from
Sep 26, 2024

Conversation

Swiftyos
Copy link
Contributor

Background

Changed blocks to be added when clicked, tweaked block cards in block list

Changes πŸ—οΈ

  • add when clicking anywhere in the block
Screenshot 2024-09-24 at 12 18 40

Testing πŸ”

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

@Swiftyos Swiftyos requested a review from a team as a code owner September 24, 2024 10:20
@Swiftyos Swiftyos requested review from Bentlybro and kcze and removed request for a team September 24, 2024 10:20
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end size/m labels Sep 24, 2024
Copy link

PR Reviewer Guide πŸ”

⏱️ Estimated effort to review: 2 πŸ”΅πŸ”΅βšͺβšͺβšͺ
πŸ§ͺΒ No relevant tests
πŸ”’Β No security concerns identified
⚑ Key issues to review

Accessibility Concern
The removal of the explicit 'Add block' button with aria-label might impact accessibility for screen reader users. Consider adding an aria-label to the new clickable Card component.

Styling Inconsistency
The removal of the border class from the Card component might lead to inconsistent styling across the application. Ensure this change is intentional and doesn't affect the overall design.

Copy link

netlify bot commented Sep 24, 2024

βœ… Deploy Preview for auto-gpt-docs ready!

Name Link
πŸ”¨ Latest commit a6bfc95
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/66f50c8fe2d3a00007d67495
😎 Deploy Preview https://deploy-preview-8147--auto-gpt-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Swiftyos Swiftyos requested a review from a team September 24, 2024 11:38
@Swiftyos
Copy link
Contributor Author

@Significant-Gravitas/maintainers Given we are so close to release. Please can you be extra diligent during reviews to ensure no bugs slip through

autogpt_platform/backend/backend/blocks/basic.py Outdated Show resolved Hide resolved
autogpt_platform/backend/backend/blocks/basic.py Outdated Show resolved Hide resolved
autogpt_platform/backend/backend/blocks/csv.py Outdated Show resolved Hide resolved
@Swiftyos Swiftyos dismissed ntindle’s stale review September 26, 2024 07:25

Was waiting for re review

@Swiftyos Swiftyos merged commit 1d2e7b8 into master Sep 26, 2024
13 checks passed
@Swiftyos Swiftyos deleted the swiftyos/secrt-889-blocks-list-ui-tweak branch September 26, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end Review effort [1-5]: 2 size/m
Projects
Status: βœ… Done
Development

Successfully merging this pull request may close these issues.

3 participants