Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Remove Sentry Pop-up and add run options #8138

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

Swiftyos
Copy link
Contributor

Background

Remove sentry popup
add run option to run with sentry disabled

Testing 🔍

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

@Swiftyos Swiftyos requested a review from a team as a code owner September 23, 2024 12:13
@Swiftyos Swiftyos requested review from Torantulino and Bentlybro and removed request for a team September 23, 2024 12:13
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end size/s and removed platform/frontend AutoGPT Platform - Front end labels Sep 23, 2024
Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Key issues to review

Conditional Sentry Enabling
The PR introduces a new environment variable 'DISABLE_SENTRY' to conditionally enable Sentry. Ensure this is properly documented and consistently used across the application.

Commented Code
The PR comments out the Sentry report dialog functionality. Consider removing this code entirely if it's no longer needed, or add a comment explaining why it's kept but disabled.

New Script Addition
A new script 'dev:nosentry' has been added. Ensure it's properly documented and its usage is clear to other developers.

Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit 1865d36
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/66f319d3fe23e70008f9b9ef
😎 Deploy Preview https://deploy-preview-8138--auto-gpt-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Pwuts Pwuts changed the title fix(sentry): Remove Sentry Pop-up and add run options fix(frontend): Remove Sentry Pop-up and add run options Sep 23, 2024
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end size/m and removed size/s labels Sep 23, 2024
@Swiftyos Swiftyos enabled auto-merge (squash) September 24, 2024 09:18
@Swiftyos Swiftyos requested a review from a team September 24, 2024 09:26
@Swiftyos
Copy link
Contributor Author

@Significant-Gravitas/maintainers Given we are so close to release. Please can you be extra diligent during reviews to ensure no bugs slip through

@Swiftyos Swiftyos enabled auto-merge (squash) September 24, 2024 16:06
@Swiftyos Swiftyos merged commit 00b8d21 into master Sep 24, 2024
12 checks passed
@Swiftyos Swiftyos deleted the remove-sentry-popup branch September 24, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants