Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(.dockerignore) Put dockerignore back #8136

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

aarushik93
Copy link
Contributor

Background

In the renaming PR, the dockerignore was erroneously moved to classic/, with the original rnd/ ignores removed. This PR fixes that.
Original PR: https://github.com/Significant-Gravitas/AutoGPT/pull/8113/files#diff-28a066e668c8be6cc7363aac4a165481d976cf684c71d238ea4c37f3d4533bf0L34

Changes 🏗️

Put .dockerignore in root, and the folders/files to ignore from autogpt_platform

Testing 🔍

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

@aarushik93 aarushik93 requested a review from a team as a code owner September 23, 2024 09:18
@aarushik93 aarushik93 requested review from ntindle, Pwuts and Swiftyos and removed request for a team September 23, 2024 09:18
Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Key issues to review

Potential Oversight
The line classic/run is added without a leading exclamation mark, which might unintentionally include this directory in the Docker context.

Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit 0d790cf
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/66f13378cf98560008a7d255
😎 Deploy Preview https://deploy-preview-8136--auto-gpt-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aarushik93 aarushik93 enabled auto-merge (squash) September 23, 2024 09:23
@aarushik93 aarushik93 merged commit fc51176 into master Sep 23, 2024
8 checks passed
@aarushik93 aarushik93 deleted the aarushikansal/fix-dockerignore branch September 23, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants