Silence various type conversion warnings #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Geraint! First off, thank you for this fantastic high-quality library. I intend to use this in OpenMPT for offline sample processing, replacing two older libraries we currently use for pitch-shifting and time-stretching.
This PR intends to silence a couple of warnings I got when compiling with MSVC with high warnings levels; similar warnings may be observed with other compilers if the warning levels are set sufficiently high. Here's a few notes on what I did:
double -> float
conversions when instantiating the Stretch template with afloat
data type rather thandouble
.size_t -> int
conversion warnings in 64-bit builds, because the base FFT classes appear to express their size in terms ofsize_t
, while other classes such asWindowedFFT
express their size in teams ofint
.int
or allsize_t
but not mixing them), but since you are in charge of the library design, I wanted to leave that decision up to you.dsp
are pulled in from another repository, so please let me know if I should open a PR there instead for those changes.