Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert autopilot route information to N2K #28

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

fabdrol
Copy link
Member

@fabdrol fabdrol commented Jul 12, 2019

This PR updates the systemTime conversion and adds an autopilot conversion, that takes NMEA0183 route data ($ECAPB, $ECXTE, $ECRMB & $ECRMC) converted into Signal K, and passes this on in the format required to generate valid PGNs.

This is a work in progress as the work needs to be tested on an actual boat before it should be released. Also, many questions remain, related to the PGNs it generates (most data in the Navigation Data PGN is not present).

Also, since this is tightly coupled to the data sent by OpenCPN at the moment, there is no selection of true or magnetic bearing to waypoint, kind of routing (rhumbline) etc

@sbender9 you have some experience with APs as well, could you review my work so far and post your thoughts?

@fabdrol fabdrol requested a review from sbender9 July 12, 2019 14:25
@fabdrol fabdrol self-assigned this Jul 12, 2019
@sbender9
Copy link
Member

Any reason not to merge this? Still WIP?

@fabdrol fabdrol changed the title [WIP] convert OpenCPN route information to N2K Convert OpenCPN route information to N2K Aug 3, 2019
@fabdrol
Copy link
Member Author

fabdrol commented Aug 3, 2019

@sbender9 just because the build fails. Thoughts on why?

@tkurki tkurki changed the title Convert OpenCPN route information to N2K Convert autopilot route information to N2K Aug 20, 2019
@tkurki
Copy link
Member

tkurki commented Aug 20, 2019

I pushed a small fix to master in an effort to fix the failing test, but I think the test is failing for a reason: if some of the inputs are missing there won't be any output.

But that is sort of besides the point: this PR also needs some tests I think. @fabdrol are you going forward with this?

@fabdrol
Copy link
Member Author

fabdrol commented Sep 18, 2019

@tkurki yes, I shall. Was off work for a bit. I'll do an update soonish

@MrMount11
Copy link

I am very interested to see this PR fulfilled. It appears that the latest work on this was over a year ago, so I don't know if it is still active.

I am using signalk and opencpn, but can not get the opencpn route data to my N2K network. I can bypass signalk and go directly from opencpn to the N2K network which works very well, so the data that is passed in the 4 nmea0183 opencpn sentences and translated to PGN's in my Yacht Devices gateway (YDNU-02) is sufficient to operate my N2K autopilot (Raymarine EV-400).

One of your notes stated the need for testing, I would be willing to test your code on my boat. I am an engineer and have done lots of programming but do not know enough of javascript to be of any help with your coding efforts.

I would appreciate any feedback. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants