feature: less verbose CORS error logging #1581
Conversation
There was a problem hiding this comment.
With this change there's no logging of failed requests, right? I have found that useful, as CORS failures are so opaque otherwise.
Setting up CORS is kinda painful. I was thinking the server could have a feature where the admin UI shows CORS failures with a button to add the origin.
|
Do you plan to continue with this? |
|
Yes, i will probably pick it up again when i'm back from sailing, unless you want to pick it up, then we can close it ;-) |
|
Instead of using the dynamic load of cors, i added an additional middleware for the specific purpose of logging potential cors-issues. Be aware that debugging cors should be done in the browser. |
|
😄 the amount and structure of the code is almost exactly the same as the original. |
tkurki
changed the title
|
I reworded the PR title a little as release notes are created from PRs, not issues, so they should be self documenting when possible. Fix or feature - or is it just a change or improvement? In the end it is in the eye of the reader 🤷 . |
Fixes #1576