Fix ReplaceStringTransformation and SigmaString plain string conversion #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reverted ReplaceStringTransformation to work on the whole SigmaString as plain string representation because backends/pipelines rely on this feature. * ReplaceStringTransformation former misbehavior of "consuming" backslashes mitigated by doubling backslashes without escaping semantics. * SigmaString now distinguishes in to_plain() method if it is in regex or string context and behaves differently on escaping. * SigmaDetectionItem.to_plain() now also distinguishes between strings andregex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the behavior of the ReplaceStringTransformation and SigmaString classes. The ReplaceStringTransformation now works on the plain string representation of the SigmaString, allowing for special characters and placeholders in the replacement. Additionally, the SigmaString class now distinguishes between regex and string context in the to_plain() method and behaves differently on escaping. The pull request also includes an option in the ReplaceStringTransformation to skip special characters in the replacement.