-
Notifications
You must be signed in to change notification settings - Fork 586
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
4eeb362
commit cd4cad7
Showing
1 changed file
with
4 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd4cad7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new colorScheme() == Qt::ColorScheme::Dark test doesn't appear to work consistently on all Linux dark themes.
Do you have any strong opinions on whether we should do this test for all platforms here, or in MainApplication like macOS is currently doing?
cd4cad7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whatever you want to do is fine. After we get something working everyplace we can try to clean things up to share as much code as possible.
I did see a Qt issue about their test failing on some Linux boxes and someone recommended some code but I don't remember what exactly. Our version of dark or light detection has worked okay, or at least I thought it did.
cd4cad7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.