make cmake 3.18 the new minimum to cleanup warnings

Sigil-Ebook · Dec 2, 2024 · 3907ad3 · 3907ad3
1 parent 08a8f18
commit 3907ad3
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/3rdparty/pcre2/CMakeLists.txt b/3rdparty/pcre2/CMakeLists.txt
@@ -103,9 +103,9 @@
 # 2023-01-15 Carlo added C99 as the minimum required
 # 2023-08-06 PH added support for setting variable length lookbehind maximum
 
-# Increased minimum to 3.5 to workaround deprecated backward compatibility
-# since 3.27.
-cmake_minimum_required(VERSION 3.5 FATAL_ERROR)
+# Increased minimum to 3.18 to workaround deprecated backward compatibility
+# since in more recent cmakes
+cmake_minimum_required(VERSION 3.18 FATAL_ERROR)
 project(PCRE2 C)
 set(CMAKE_C_STANDARD 99)
 set(CMAKE_C_STANDARD_REQUIRED TRUE)

diff --git a/3rdparty/zlib/CMakeLists.txt b/3rdparty/zlib/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 2.4.4...3.15.0)
+cmake_minimum_required(VERSION 3.18)
 set(CMAKE_ALLOW_LOOSE_LOOP_CONSTRUCTS ON)
 
 project(zlib C)

diff --git a/internal/gumbo/CMakeLists.txt b/internal/gumbo/CMakeLists.txt
@@ -7,7 +7,7 @@
 #
 #########################################################
 
-cmake_minimum_required( VERSION 3.5 ) 
+cmake_minimum_required( VERSION 3.18 ) 
 
 project( sigilgumbo C )
 

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
@@ -656,7 +656,7 @@ endif()
 
 # Building Sigil with Qt6 requires cmake 3.16+
 # and a C++17 standards compatible compiler
-cmake_minimum_required( VERSION 3.16 )
+cmake_minimum_required( VERSION 3.18 )
 
 set(CMAKE_CXX_STANDARD 17)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)