clean up build warnings and deprecations

Sigil-Ebook · Mar 1, 2024 · 6013e8b · 6013e8b
1 parent 7201375
commit 6013e8b
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 2 deletions.
diff --git a/CMakeLists5.txt b/CMakeLists5.txt
@@ -18,6 +18,10 @@ endif()
 find_package(Qt5 ${QT5_NEEDED} COMPONENTS Core Network WebEngine WebEngineWidgets Svg Widgets PrintSupport Xml LinguistTools)
 set(CMAKE_AUTOMOC ON)
 
+if (CMAKE_VERSION VERSION_GREATER "3.27.9")
+    cmake_policy(SET CMP0153 OLD)
+endif()
+
 set( SOURCE_FILES
     main.cpp
     MainApplication.cpp

diff --git a/CMakeLists6.txt b/CMakeLists6.txt
@@ -15,6 +15,10 @@ set(CMAKE_CXX_EXTENSIONS OFF)
 
 #############################################################################
 
+if (CMAKE_VERSION VERSION_GREATER "3.27.9")
+    cmake_policy(SET CMP0153 OLD)
+endif()
+
 if( UNIX AND NOT APPLE )
     # Qt6 packages minimum version 6.2 for Linux
     set(QT6_NEEDED 6.2)

diff --git a/SelectFiles.cpp b/SelectFiles.cpp
@@ -299,7 +299,7 @@ void SelectFiles::resizeEvent(QResizeEvent *event)
 void SelectFiles::SetPreviewImage()
 {
     m_PreviewReady = false;
-    QPixmap(pixmap);
+    QPixmap pixmap;
     QString details = "";
     QStandardItem *item = GetLastSelectedImageItem();
 

diff --git a/UIDictionary.cpp b/UIDictionary.cpp
@@ -57,7 +57,7 @@ QString UIDictionary::GetDictionaryPath()
 
     // finally look inside the installed Qt directories
 #ifndef Q_OS_MAC
-    dict_path = QLibraryInfo::location(QLibraryInfo::DataPath) + "/qtwebengine_dictionaries";
+    dict_path = QLibraryInfo::path(QLibraryInfo::DataPath) + "/qtwebengine_dictionaries";
 #else
     dict_path = QCoreApplication::applicationDirPath() + 
       "/../Frameworks/QtWebEngineCore.framework/Resources/qtwebengine_dictionaries";

diff --git a/main.cpp b/main.cpp
@@ -403,6 +403,7 @@ int main(int argc, char *argv[])
 
     // initialize our QWebEngineProfiles and URL Interceptor
     WebProfileMgr* profile_mgr = WebProfileMgr::instance();
+    Q_UNUSED(profile_mgr);
 
     QStringList arguments = QCoreApplication::arguments();