Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update rewards params to update new reward parameters #3433

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

snobbee
Copy link
Contributor

@snobbee snobbee commented Dec 4, 2023

  • reward update msg to update new rewards distribute parameter
  • reward update msg to update new rewards epoch identifier parameter
  • reward update msg to update new rewards lock period parameter

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #3433 (f7bf348) into master (0c63583) will increase coverage by 0.98%.
Report is 11 commits behind head on master.
The diff coverage is 58.36%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3433      +/-   ##
==========================================
+ Coverage   43.35%   44.34%   +0.98%     
==========================================
  Files         166      183      +17     
  Lines       15895    16736     +841     
==========================================
+ Hits         6891     7421     +530     
- Misses       8591     8870     +279     
- Partials      413      445      +32     
Files Coverage Δ
app/app.go 94.42% <100.00%> (+4.31%) ⬆️
cmd/sifnoded/cmd/ibc-diag.go 15.74% <ø> (ø)
x/clp/keeper/executors.go 58.82% <100.00%> (+0.30%) ⬆️
x/clp/types/codec.go 100.00% <100.00%> (ø)
x/clp/types/key_rewards_bucket.go 100.00% <100.00%> (ø)
x/clp/types/keys.go 85.36% <100.00%> (+2.03%) ⬆️
x/clp/types/querier.go 100.00% <ø> (ø)
x/clp/types/types.go 97.14% <100.00%> (+0.26%) ⬆️
x/dispensation/types/types.go 100.00% <100.00%> (ø)
x/epochs/keeper/abci.go 100.00% <100.00%> (ø)
... and 26 more

... and 2 files with indirect coverage changes

Copy link
Contributor

@pgoos pgoos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snobbee snobbee merged commit b4760fc into master Dec 4, 2023
7 checks passed
@snobbee snobbee deleted the feat/update-rewards-params branch December 4, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants