chore: Cleanup deprecated parameter usage for Terraform

SierraSoftworks · Aug 2, 2024 · a66cd0c · a66cd0c
1 parent 0e737b5
commit a66cd0c
Showing 1 changed file with 22 additions and 22 deletions.
diff --git a/infra/github-actions.tf b/infra/github-actions.tf
@@ -8,7 +8,7 @@ resource "azuread_application" "deploy-production" {
 }
 
 resource "azuread_service_principal" "deploy-production" {
-  application_id               = azuread_application.deploy-production.application_id
+  client_id                    = azuread_application.deploy-production.client_id
   app_role_assignment_required = false
   owners = [
     data.azuread_client_config.current.object_id,
@@ -22,38 +22,38 @@ resource "azuread_application" "deploy-staging" {
 }
 
 resource "azuread_service_principal" "deploy-staging" {
-  application_id               = azuread_application.deploy-staging.application_id
+  client_id                    = azuread_application.deploy-staging.client_id
   app_role_assignment_required = false
   owners = [
     data.azuread_client_config.current.object_id,
   ]
 }
 
 resource "azuread_application_federated_identity_credential" "production" {
-  application_object_id = azuread_application.deploy-production.object_id
-  display_name          = "Environment"
-  description           = "Allows deployments from GitHub Actions to the 'Production' environment."
-  audiences             = ["api://AzureADTokenExchange"]
-  issuer                = "https://token.actions.githubusercontent.com"
-  subject               = "repo:${var.repository}:environment:${var.production-environment}"
+  application_id = azuread_application.deploy-production.object_id
+  display_name   = "Environment"
+  description    = "Allows deployments from GitHub Actions to the 'Production' environment."
+  audiences      = ["api://AzureADTokenExchange"]
+  issuer         = "https://token.actions.githubusercontent.com"
+  subject        = "repo:${var.repository}:environment:${var.production-environment}"
 }
 
 resource "azuread_application_federated_identity_credential" "staging" {
-  application_object_id = azuread_application.deploy-staging.object_id
-  display_name          = "Environment"
-  description           = "Allows deployments from GitHub Actions to the 'Staging' environment."
-  audiences             = ["api://AzureADTokenExchange"]
-  issuer                = "https://token.actions.githubusercontent.com"
-  subject               = "repo:${var.repository}:environment:${var.staging-environment}"
+  application_id = azuread_application.deploy-staging.object_id
+  display_name   = "Environment"
+  description    = "Allows deployments from GitHub Actions to the 'Staging' environment."
+  audiences      = ["api://AzureADTokenExchange"]
+  issuer         = "https://token.actions.githubusercontent.com"
+  subject        = "repo:${var.repository}:environment:${var.staging-environment}"
 }
 
 resource "azuread_application_federated_identity_credential" "prs" {
-  application_object_id = azuread_application.deploy-staging.object_id
-  display_name          = "PRs"
-  description           = "Allows deployments from GitHub Actions for pull requests."
-  audiences             = ["api://AzureADTokenExchange"]
-  issuer                = "https://token.actions.githubusercontent.com"
-  subject               = "repo:${var.repository}:pull_request"
+  application_id = azuread_application.deploy-staging.object_id
+  display_name   = "PRs"
+  description    = "Allows deployments from GitHub Actions for pull requests."
+  audiences      = ["api://AzureADTokenExchange"]
+  issuer         = "https://token.actions.githubusercontent.com"
+  subject        = "repo:${var.repository}:pull_request"
 }
 
 resource "azurerm_role_assignment" "deploy-production" {
@@ -72,14 +72,14 @@ output "deploy-production" {
   value = {
     tenant_id       = data.azuread_client_config.current.tenant_id
     subscription_id = data.azurerm_subscription.current.subscription_id
-    client_id       = azuread_application.deploy-production.application_id
+    client_id       = azuread_application.deploy-production.client_id
   }
 }
 
 output "deploy-staging" {
   value = {
     tenant_id       = data.azuread_client_config.current.tenant_id
     subscription_id = data.azurerm_subscription.current.subscription_id
-    client_id       = azuread_application.deploy-staging.application_id
+    client_id       = azuread_application.deploy-staging.client_id
   }
 }