Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strengthen #216

Open
wants to merge 73 commits into
base: master
Choose a base branch
from
Open

strengthen #216

wants to merge 73 commits into from

Conversation

yika-aixi
Copy link

multi Node Window

treeviewMenu

DynamicPortList Do not force index latent rules
supportRenameList

@yika-aixi
!W 加入了IcSkillSystme连接
ba47fbd
@yika-aixi
!T 调整了绘制顺序
113eb4b
@yika-aixi
!B 没有过滤保护和内部等其他类型字段,导致出现多次
574e345
@yika-aixi
!T 忽略meta
d6e64f8
@yika-aixi
!D meta
ee68490
@yika-aixi
!W Input新增了一个BaseType得指定,当TypeConstraint为TypeConstraint.Inherited时可用
3a1b594
@yika-aixi
!B 节点创建时没有设置Input的TypeConstraintBaseType
3134dc1
@yika-aixi
!W 新增了一个获取当前节点鼠标在Group中的坐标
354f7d1
@yika-aixi
!W 绘制不可被unity序列化的类型端口
38df17b
@yika-aixi
!W 动态Port新增了一个删除
0602d3f
@yika-aixi
!OW 让使用者可以自定义不需要显示的字段
2017fc8
@yika-aixi
!B Group 空问题
25514fc
@yika-aixi
!W 加了一个创建当前Group所支持的所有节点功能,用于调试
7c3c106
@yika-aixi
!B 坐标计算错误
9be869f
@yika-aixi
!T 回滚绘制顺序,太难看了,哈哈
40db69a
@yika-aixi
!W 输出端口索引显示
fdd42a8
@yika-aixi
!W 绘制GroupName
46d0933
@yika-aixi
!O 调整了GroupName 绘制得顺序,如果连接数只有一个不显示索引,索引数+1
2248e0f
@yika-aixi
!W 右键添加节点的方式从GenericMenu改为PopupWindow,目前有个小bug,点出线后,右键本来应该是取消线的选择…
eb3d24f 
…状态,但目前无法,后续在解决,问题不大=-=
@yika-aixi
!W 搜索时按下↓键切换焦点到TreeView
0721750
@yika-aixi
!T 加一个最小尺寸
284ecdd
@yika-aixi
!B 节点选择窗口无法关闭
02f5998
@yika-aixi
!W GenericMenu改为MenuPopupWindow
cfb4d2c
@yika-aixi
!W
1691e4c
@yika-aixi
!B 端口连接后,没有释放连接线
2b21b0d
@yika-aixi
!W 一个关闭所有Node Editor Window窗口的菜单项
0893d3b
@yika-aixi
!T(Node Editor Window Action) 右键Node恢复为GenericMenu
1fece9c
@yika-aixi
!O(Dynamic Port List) 默认实现存在潜规则,删除了潜规则
413f4e2
@yika-aixi
Merge branch 'Cabin_Icarus' of https://github.com/yika-aixi/xNode int…
5b8a751 
…o Cabin_Icarus
@yika-aixi
!O(NodeEditorGUILayout) DynamicPortList
2c45dd4
@Siccity
Copy link
Owner

Siccity commented Dec 15, 2019

You have a lot of neat features here. Please follow contributing guidelines if you wish to contribute

@yika-aixi
Copy link
Author

You have a lot of neat features here. Please follow contributing guidelines if you wish to contribute

OK, let me see

@yika-aixi
Copy link
Author

I standardized the naming and removed duplicate implementations.You review, it is not very convenient to split the submission.I need to create many branches to extract commits.

@Siccity
Copy link
Owner

Siccity commented Dec 23, 2019

I'm sorry, but this PR will take a very long time to review, and thus it will not be merged.
I will keep it around as an open PR for future reference.
Some immediate issues is the removal of .meta files and the inconsistent code formatting.

@yika-aixi
Copy link
Author

I'm sorry, but this PR will take a very long time to review, and thus it will not be merged.
I will keep it around as an open PR for future reference.
Some immediate issues is the removal of .meta files and the inconsistent code formatting.

meta file was deleted is because no in the library any scripts to be referenced, so I deleted him

@yika-aixi
Copy link
Author

I'm sorry, but this PR will take a very long time to review, and thus it will not be merged.
I will keep it around as an open PR for future reference.
Some immediate issues is the removal of .meta files and the inconsistent code formatting.

Code format, I look at the code, I may have forgotten to change it, sorry

@yika-aixi
!TX(Code format)
5d22596
@yika-aixi
!TX(Code format)
6ecef29
@yika-aixi
Merge remote-tracking branch 'remotes/Siccity/master' into Cabin_Icarus
d35fba4 
# Conflicts:
#	Scripts/Editor/NodeEditorWindow.cs
@yika-aixi
!TX(Code format) var to concrete Type
33a516b
@yika-aixi
!B(NodeEditorWindow) multiple NodeEditorWindow,Target error
daf7fb9
@yika-aixi
!I Siccity/master -> yika-aixi/Cabin_Icarus
7a7c0ff 
# Conflicts:
#	.gitignore
#	Scripts/Editor/NodeEditor.cs
#	Scripts/Editor/NodeEditorAction.cs
#	Scripts/Editor/NodeEditorGUILayout.cs
#	Scripts/Editor/NodeGraphEditor.cs
#	Scripts/NodeDataCache.cs
@yika-aixi
!W OnRename
570e01d
@AKJ1
Copy link

AKJ1 commented Jun 26, 2020

Woah, this is a wild PR. yika's branch is usable with 2019.4 LTS and fixes #117, for any googlers that end up searching for a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yika-aixi @Siccity @AKJ1