ci: use workflow templates #1615
Open
+15
−315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8maninger
force-pushed
the
nate/use-default-workflow
branch
from
01e87d2
to
8b2accc
Compare
There was a problem hiding this comment.
Tbh not having mysql tests is a bit of a dealbreaker for me. I'd hold off on merging this until we have extended the common workflow with support for MySQL
There was a problem hiding this comment.
Im not certain the common workflow should support MySQL. None of the other apps will ever support it.
There was a problem hiding this comment.
We can probably append the MySQL job as an extra step at the end of the workflow file
There was a problem hiding this comment.
We should probably prioritize getting linux and homebrew builds running. It would be awkward to stop releasing on linux mid-beta.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No support for deb packaging, homebrew, or MySQL tests