Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix semver validation #486

Merged
merged 1 commit into from
Oct 20, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 9 additions & 16 deletions build/gen.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,26 +75,19 @@ func getGitMeta() (meta gitMeta, _ error) {
return
}

func validSemVer(tag string) error {
func validSemVer(tag string) bool {
if len(tag) == 0 || tag[0] != 'v' {
return errors.New("semver must start with 'v'")
return false
}

var major, minor, patch int
_, err := fmt.Sscanf(tag, "v%d.%d.%d", &major, minor, patch)
var major, minor, patch uint8
_, err := fmt.Sscanf(tag, "v%d.%d.%d", &major, &minor, &patch)
if err != nil {
return fmt.Errorf("failed to parse semver: %w", err)
return false
} else if major == 0 && minor == 0 && patch == 0 {
return false
}

switch {
case major <= 0:
return errors.New("major version must be greater than 0")
case minor <= 0:
return errors.New("minor version must be greater than 0")
case patch <= 0:
return errors.New("patch version must be greater than 0")
}
return nil
return true
}

func main() {
Expand All @@ -105,7 +98,7 @@ func main() {

commit := meta.ShortCommit
version := meta.Tag
if err := validSemVer(meta.Tag); err != nil {
if !validSemVer(meta.Tag) {
// no version, use commit and current time for development
version = commit
meta.Timestamp = gitTime(time.Now())
Expand Down
Loading