Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support V2 Multi-Announcements #471

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 3, 2024

Bumps the all-dependencies group with 3 updates in the / directory: github.com/cloudflare/cloudflare-go, go.sia.tech/core and go.sia.tech/coreutils.

Updates github.com/cloudflare/cloudflare-go from 0.104.0 to 0.106.0

Release notes

Sourced from github.com/cloudflare/cloudflare-go's releases.

v0.106.0

ENHANCEMENTS:

  • access_application: added target contexts support for access application type infrastructure (#3186)
  • access_policy: added infrastructure connection rule support for access policy (#3186)

v0.105.0

ENHANCEMENTS:

  • device_posture_rule: add score field for custom_s2s posture rule (#3031)
  • infrastructure_targets: initialize CRUD endpoints for infrastructure access endpoints (#3184)
  • load_balancing: add account load balancer support (#3027)
Changelog

Sourced from github.com/cloudflare/cloudflare-go's changelog.

0.106.0 (September 27th, 2024)

ENHANCEMENTS:

  • access_application: added target contexts support for access application type infrastructure (#3186)
  • access_policy: added infrastructure connection rule support for access policy (#3186)

0.105.0 (September 25th, 2024)

ENHANCEMENTS:

  • device_posture_rule: add score field for custom_s2s posture rule (#3031)
  • infrastructure_targets: initialize CRUD endpoints for infrastructure access endpoints (#3184)
  • load_balancing: add account load balancer support (#3027)
Commits
  • e9034aa Update CHANGELOG.md
  • d6ec26a generate changelog
  • 5958d1b Merge pull request #3250 from SaiDadireddy/sdadireddy/infra-app
  • f7dbab2 expand Infra => Infrastructure with correct namespace
  • 8c36601 add changelog
  • 4721188 small fix
  • 12ad68e Add connection rules to access policy tests
  • e27fa59 Struct types should use pointers as they are optional
  • 24fb45c Move infra related types to appropriate file
  • 76fa2f7 Cleanup comments
  • Additional commits viewable in compare view

Updates go.sia.tech/core from 0.4.6 to 0.4.7

Commits
  • 72daac0 Merge pull request #207 from SiaFoundation/preimage-len
  • 7a2ef40 types: Switch to fixed-length PolicyHash preimage
  • 0f61e58 Merge pull request #205 from SiaFoundation/proof-supplement
  • a176ef9 consensus: Add V1StorageProofSupplement, fixing encoding bug
  • 37cd8b8 build(deps): bump go.sia.tech/mux in the all-dependencies group
  • e21edfd Merge pull request #201 from SiaFoundation/nate/upgrade-go
  • 708363a ci,deps: upgrade go, switch to common workflow
  • 2cdf6f6 Merge pull request #196 from SiaFoundation/nate/v2-revision-ordering
  • 3dcc8ac consensus: Validate against earlier v2 contract revisions in block
  • 300042f build(deps): bump the all-dependencies group with 2 updates
  • Additional commits viewable in compare view

Updates go.sia.tech/coreutils from 0.3.2 to 0.4.0

Commits
  • 44117d3 rhp4: address review comments
  • 3543c96 rhp4: add proof validation comment
  • c1dddb9 rhp4: use clear for zero reader (Chris)
  • 9dc122d rhp4: switch RPCWrite to streaming
  • a80d6d9 rhp4: period in docstring
  • 4977cf4 rhp4,chain: remove slashes in protocol
  • 19326ed rhp4: make input validation clearer
  • 48da7a3 rhp4: address comments
  • ab3a7bd rhp4: add result types
  • 2e81244 rhp/v4: fix modify sectors test
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

…3 updates

Bumps the all-dependencies group with 3 updates in the / directory: [github.com/cloudflare/cloudflare-go](https://github.com/cloudflare/cloudflare-go), [go.sia.tech/core](https://github.com/SiaFoundation/core) and [go.sia.tech/coreutils](https://github.com/SiaFoundation/coreutils).


Updates `github.com/cloudflare/cloudflare-go` from 0.104.0 to 0.106.0
- [Release notes](https://github.com/cloudflare/cloudflare-go/releases)
- [Changelog](https://github.com/cloudflare/cloudflare-go/blob/master/CHANGELOG.md)
- [Commits](cloudflare/cloudflare-go@v0.104.0...v0.106.0)

Updates `go.sia.tech/core` from 0.4.6 to 0.4.7
- [Commits](SiaFoundation/core@v0.4.6...v0.4.7)

Updates `go.sia.tech/coreutils` from 0.3.2 to 0.4.0
- [Commits](SiaFoundation/coreutils@v0.3.2...v0.4.0)

---
updated-dependencies:
- dependency-name: github.com/cloudflare/cloudflare-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: go.sia.tech/core
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-dependencies
- dependency-name: go.sia.tech/coreutils
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 3, 2024
@n8maninger n8maninger changed the title build(deps): bump the all-dependencies group across 1 directory with 3 updates Support V2 Multi-Announcements Oct 3, 2024
SetLastAnnouncement(Announcement) error

// LastV2AnnouncementHash returns the last v2 announcement.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// LastV2AnnouncementHash returns the last v2 announcement.
// LastV2AnnouncementHash returns the hash of the last v2 announcement.

// re-announce
if err := m.Announce(); err != nil {
m.log.Warn("failed to announce", zap.Error(err))
if !shouldAnnounce {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit would invert

if shouldAnnounce {
    if err := cm.Announce(); err != nil {
        cm.log.Warn("failed to announce", zap.Error(err))
    }
}
return nil

@peterjan
Copy link
Member

peterjan commented Oct 4, 2024

approved but seems like there's an non deterministic deadlock in the tests somewhere 👀

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 5, 2024

Looks like these dependencies are updatable in another way, so this is no longer needed.

@dependabot dependabot bot closed this Oct 5, 2024
@dependabot dependabot bot deleted the dependabot/go_modules/all-dependencies-7eaabff0b0 branch October 5, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants