Skip to content

Commit

Permalink
build: fix semver validation
Browse files Browse the repository at this point in the history
  • Loading branch information
n8maninger committed Oct 20, 2024
1 parent 319f32e commit 10794ed
Showing 1 changed file with 9 additions and 16 deletions.
25 changes: 9 additions & 16 deletions build/gen.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,26 +75,19 @@ func getGitMeta() (meta gitMeta, _ error) {
return
}

func validSemVer(tag string) error {
func validSemVer(tag string) bool {
if len(tag) == 0 || tag[0] != 'v' {
return errors.New("semver must start with 'v'")
return false
}

var major, minor, patch int
_, err := fmt.Sscanf(tag, "v%d.%d.%d", &major, minor, patch)
var major, minor, patch uint8
_, err := fmt.Sscanf(tag, "v%d.%d.%d", &major, &minor, &patch)
if err != nil {
return fmt.Errorf("failed to parse semver: %w", err)
return false
} else if major == 0 && minor == 0 && patch == 0 {
return false
}

switch {
case major <= 0:
return errors.New("major version must be greater than 0")
case minor <= 0:
return errors.New("minor version must be greater than 0")
case patch <= 0:
return errors.New("patch version must be greater than 0")
}
return nil
return true
}

func main() {
Expand All @@ -105,7 +98,7 @@ func main() {

commit := meta.ShortCommit
version := meta.Tag
if err := validSemVer(meta.Tag); err != nil {
if !validSemVer(meta.Tag) {
// no version, use commit and current time for development
version = commit
meta.Timestamp = gitTime(time.Now())
Expand Down

0 comments on commit 10794ed

Please sign in to comment.