Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dream PCell: ebeam_dream_lens_edge_couplers #299

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

mustafacc
Copy link
Member

parameterized for 1310/1550 and any number of channels

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 91.53846% with 11 lines in your changes missing coverage. Please review.

Project coverage is 73.70%. Comparing base (11ed944) to head (30b3e30).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...am_Dream/ebeam_dream_microlens_edge_couplers_BB.py 91.53% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
+ Coverage   73.50%   73.70%   +0.19%     
==========================================
  Files          97       98       +1     
  Lines       11870    12000     +130     
==========================================
+ Hits         8725     8844     +119     
- Misses       3145     3156      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukasc-ubc lukasc-ubc merged commit 6b873f8 into SiEPIC:master Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants