Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added PCell - Bobby #263

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Added PCell - Bobby #263

merged 3 commits into from
Nov 10, 2023

Conversation

Hang-Bobby-Zou
Copy link
Contributor

No description provided.

@lukasc-ubc
Copy link
Member

  • typo in "Taperl" in strip_taper
  • instantiating the PCells, they have a * at the end of the cell name after instantiation. This is some kind of error. What is required is an extra def, for example:
    def display_text_impl(self):
        # Provide a descriptive text for the cell
        return "strip_taper(L=" + ('%.3f' % (self.taperL) ) + ")"
  • DevRec layer should not be co-incident with the waveguide. Leave at least 500 nm space.
  • there is a taper pcell in the "EBeam" library. Do we need another? Also there is even better one in this PDK, where the length is automatically calculated: ZEP
image

@Hang-Bobby-Zou
Copy link
Contributor Author

Hi Lukas, thanks for reviewing, let me take a look and make modifications.

@Hang-Bobby-Zou
Copy link
Contributor Author

Hi Lukas, can you please specify, for which device does the DevRec coincident with the waveguide? I cannot find any overlaps
image

@Hang-Bobby-Zou
Merge branch 'SiEPIC:master' into master
e196e2c
@Hang-Bobby-Zou
Updated cells for e_skid, removed the strip_taper cell
7a7c465 
- Remove strip_taper.py since initially I thought this was a dependency for another PCell
- Changed device naming for the e_skid structure with one sided taper (from e_skid_left_taper.py to e_skid_single_side_taper.py
- Changed the divider from TypeBoolean to TypeNone so the PCell menu tab looks a bit better
- Resolved the naming issue with * at the end
- Moved DevRec away from the structures so it does not co-incident with the waveguide anymore
@lukasc-ubc lukasc-ubc merged commit deed76b into SiEPIC:master Nov 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hang-Bobby-Zou @lukasc-ubc