Fix zookeeper connection leak #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanth96
force-pushed
the
zk-conn-fix
branch
2 times, most recently
from
bd4695c to
7f400c8
Compare
shanth96
force-pushed
the
zk-conn-fix
branch
2 times, most recently
from
319e559 to
c534303
Compare
brendar
reviewed
Oct 28, 2024
shanth96
changed the base branch from
v18.0.5-shopify-6
to
v18.0.5-shopify-6-candidate
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://github.com/Shopify/vitess-project/issues/696
This PR closes the connection to the topo server whenever we get disconnected from zookeeper. This is to fix the connection/memory leak as described in the issue. It also adds additional logging whenever the connection is closed
Related Issue(s)
Checklist
Deployment Notes