Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V18.0.5 shopify 1 candidate #162

Merged
merged 8 commits into from
May 14, 2024
Merged

V18.0.5 shopify 1 candidate #162

merged 8 commits into from
May 14, 2024

Conversation

shivnagarajan
Copy link

@shivnagarajan shivnagarajan commented May 9, 2024 •
edited
Loading

These are the changes needed for v18.0.5

The following commits are necessary for target version 18.0.5:
8390560c27125ba62dfdfd3853e67d141bd0d268, PR: 146
62a60b22f515d61d7f7d90fff87b4505e8d4f081, PR: 102
6bc3c088c815e910550f62dbb91bc529c49d023b, PR: 148
dde12107e0b1c5e4d1804b77ac538fad108fbd30, PR: 155
6a86fc9d6c258c5f03b69830c0aad286cc9fe4d1, PR: 161
aa73e7fb7d91c6a8fc76a7af5665e7da894ccf06, PR: 164

The following commits have already been applied to v18.0.5-shopify-1-candidate:

8390560c27125ba62dfdfd3853e67d141bd0d268, PR: 146
62a60b22f515d61d7f7d90fff87b4505e8d4f081, PR: 102
6bc3c088c815e910550f62dbb91bc529c49d023b, PR: 148
dde12107e0b1c5e4d1804b77ac538fad108fbd30, PR: 155
6a86fc9d6c258c5f03b69830c0aad286cc9fe4d1, PR: 161
aa73e7fb7d91c6a8fc76a7af5665e7da894ccf06, PR: 164

All commits have been applied.

Description

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

pawandubey
pawandubey approved these changes May 9, 2024
View reviewed changes
Copy link

@pawandubey pawandubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR numbers make sense based on labels.

@shivnagarajan shivnagarajan force-pushed the v18.0.5-shopify-1-candidate branch from 29140ff to 9db7c01 Compare May 9, 2024 17:43
jeremycole and others added 5 commits May 9, 2024 14:44
@jeremycole @shivnagarajan
Add new placement Vindex strategy
b0cad30 
Signed-off-by: Jeremy Cole <[email protected]>

Sprinkle addPadding everywhere when comparing KeyRange Start/End values

Implement support for PartialVindex usage

Signed-off-by: Jeremy Cole <[email protected]>
(cherry picked from commit 7424fff)
(cherry picked from commit 69e6248)
(cherry picked from commit 8390560)
@brendar @shivnagarajan
Merge pull request #102 from Shopify/generate-cachedsize-for-placemen…
f258063 
…t-vindex

Generate CachedSize function for Placement vindex

(cherry picked from commit 986ffc6)
(cherry picked from commit 1fe7126)
(cherry picked from commit 62a60b2)
@shanth96 @shivnagarajan
Merge pull request #148 from Shopify/fix-tests
33b5962 
Run all relevant tests on all PRs

(cherry picked from commit b55dd26)
(cherry picked from commit 8feee14)
(cherry picked from commit 6bc3c08)
@pawandubey @shivnagarajan
Merge pull request #155 from Shopify/candidate-v15.0.3-shopify-11
fabdae5 
Backport: set vreplication net read and net write timeout session vars to high values
(cherry picked from commit 84ea974)
(cherry picked from commit 5cc2dfc)
(cherry picked from commit dde1210)
@shivnagarajan
Merge pull request #161 from Shopify/fix_e2e_test_v17
a4df282 
fix for e2e test issue on v17

(cherry picked from commit 6a86fc9)
@shivnagarajan shivnagarajan force-pushed the v18.0.5-shopify-1-candidate branch 2 times, most recently from 3bce857 to a4df282 Compare May 10, 2024 14:20
@shivnagarajan shivnagarajan mentioned this pull request May 10, 2024
Merged
5 tasks
@shivnagarajan
fix tests for CI
5cf9f24 
run make generate_ci_workflows
similar to #148
remove custome machines for runs-on
run make generate_ci_workflows
use ubuntu
@shivnagarajan
fix vreplication_test
c3f3417
@shivnagarajan
Merge pull request #164 from Shopify/fix_tests_for_v18
aa73e7f 
fix tests for CI
@shivnagarajan
Copy link
Author

shivnagarajan commented May 10, 2024 •
edited
Loading 

The following commits are necessary for target version 18.0.5:
8390560c27125ba62dfdfd3853e67d141bd0d268, PR: 146
62a60b22f515d61d7f7d90fff87b4505e8d4f081, PR: 102
6bc3c088c815e910550f62dbb91bc529c49d023b, PR: 148
dde12107e0b1c5e4d1804b77ac538fad108fbd30, PR: 155
6a86fc9d6c258c5f03b69830c0aad286cc9fe4d1, PR: 161
aa73e7fb7d91c6a8fc76a7af5665e7da894ccf06, PR: 164

The following commits have already been applied to v18.0.5-shopify-1-candidate:

8390560c27125ba62dfdfd3853e67d141bd0d268, PR: 146
62a60b22f515d61d7f7d90fff87b4505e8d4f081, PR: 102
6bc3c088c815e910550f62dbb91bc529c49d023b, PR: 148
dde12107e0b1c5e4d1804b77ac538fad108fbd30, PR: 155
6a86fc9d6c258c5f03b69830c0aad286cc9fe4d1, PR: 161
aa73e7fb7d91c6a8fc76a7af5665e7da894ccf06, PR: 164

All commits have been applied.

@shivnagarajan
Copy link
Author

This image has also been successfully built here

@shivnagarajan shivnagarajan merged commit f10e224 into v18.0.5-shopify-1 May 14, 2024
209 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanth96 shanth96 shanth96 approved these changes

@pawandubey pawandubey pawandubey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shivnagarajan @pawandubey @shanth96 @jeremycole @brendar