Backport: Vindexes: Pass context in consistent lookup handleDup (#14653) #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brendan Dougherty <[email protected]>
shanth96
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
LGTM. I also created https://docs.google.com/spreadsheets/d/1DyFUcykyaU7M3VtIfyWyYppK4I2usvEKocqJ6biKFOY/edit#gid=0 to keep track of all of our commits, could you add a record in there when you merge this?
austenLacy
approved these changes
Jan 16, 2024
|
Github workflows are failing because a MySQL apt key has changed, but unit tests pass locally. I'm going to merge this then open another PR to backport the apt key fix. |
shanth96
pushed a commit
that referenced
this pull request
Mar 21, 2024
…r-id-error-with-consistent-lookup-vindexes Backport: Vindexes: Pass context in consistent lookup handleDup (vitessio#14653) (cherry picked from commit aacae86)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport vitessio#14653