Backport fix for Vitess Online DDL atomic cut-over #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* cut-over with sentry table Signed-off-by: Shlomi Noach <[email protected]> * wait for rename via channel; write extra transaction post LOCK Signed-off-by: Shlomi Noach <[email protected]> * add stage info Signed-off-by: Shlomi Noach <[email protected]> * reduced wait-for-pos timeout. Improved stage logic Signed-off-by: Shlomi Noach <[email protected]> * cleanup Signed-off-by: Shlomi Noach <[email protected]> * more cleanup Signed-off-by: Shlomi Noach <[email protected]> * even more cleanup Signed-off-by: Shlomi Noach <[email protected]> * context timeout Signed-off-by: Shlomi Noach <[email protected]> * preserve stage by disabling deferred stage changes Signed-off-by: Shlomi Noach <[email protected]> * killing rename query upon error Signed-off-by: Shlomi Noach <[email protected]> * increase test timeout Signed-off-by: Shlomi Noach <[email protected]> * fix defer ordering Signed-off-by: Shlomi Noach <[email protected]> * log.info Signed-off-by: Shlomi Noach <[email protected]> * add and populate cutover_attempts column Signed-off-by: Shlomi Noach <[email protected]> * search PROCESSLIST with LIKE Signed-off-by: Shlomi Noach <[email protected]> * code comment Signed-off-by: Shlomi Noach <[email protected]> * making a variable more local Signed-off-by: Shlomi Noach <[email protected]> * literal string Signed-off-by: Shlomi Noach <[email protected]> Signed-off-by: Shlomi Noach <[email protected]>
austenLacy
changed the title
austenLacy
changed the title
|
@brendar The upstream PR was merged and I confirmed these changes all match. I updated the base of this PR to be the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports an upstream fix for online DDL table rename cutover. We need to be very careful with this back port and should definitely be tested before being merged and deployed. Unfortunately unit/e2e testing is hard for this because the failure case is inherently flaky in a codified test. However, we have a reproducible example of the error it is meant to fix and we can confirm that works and that other schema changes continue to work.
ref: https://github.com/Shopify/shardlifter-project/issues/103