Replication logs

Shopify · Oct 10, 2024 · cf566e1 · cf566e1
1 parent 6b24a14
commit cf566e1
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 0 deletions.
diff --git a/go/vt/discovery/tablet_picker.go b/go/vt/discovery/tablet_picker.go
@@ -399,6 +399,7 @@ func (tp *TabletPicker) GetMatchingTablets(ctx context.Context) []*topo.TabletIn
 			// Match cell, keyspace, and shard.
 			sri, err := tp.ts.GetShardReplication(shortCtx, cell, tp.keyspace, tp.shard)
 			if err != nil {
+				log.Warningf("ShardReplication -- GetMatchingTablets failed for cell %s, keyspace %s, shard %s: %v", cell, tp.keyspace, tp.shard, err)
 				continue
 			}
 			for _, node := range sri.Nodes {

diff --git a/go/vt/topo/helpers/compare.go b/go/vt/topo/helpers/compare.go
@@ -25,6 +25,7 @@ import (
 
 	"context"
 
+	"vitess.io/vitess/go/vt/log"
 	"vitess.io/vitess/go/vt/proto/vtrpc"
 	"vitess.io/vitess/go/vt/topo"
 	"vitess.io/vitess/go/vt/vterrors"
@@ -164,10 +165,12 @@ func CompareShardReplications(ctx context.Context, fromTS, toTS *topo.Server) er
 			for _, cell := range cells {
 				fromSRi, err := fromTS.GetShardReplication(ctx, cell, keyspace, shard)
 				if err != nil {
+					log.Warningf("GetShardReplication-- FromTS.CompareShardReplications failed for cell %s, keyspace %s, shard %s: %v", cell, keyspace, shard, err)
 					return vterrors.Wrapf(err, "GetShardReplication(%v, %v, %v)", cell, keyspace, shard)
 				}
 				toSRi, err := toTS.GetShardReplication(ctx, cell, keyspace, shard)
 				if err != nil {
+					log.Warningf("GetShardReplication-- toTS.CompareShardReplications failed for cell %s, keyspace %s, shard %s: %v", cell, keyspace, shard, err)
 					return vterrors.Wrapf(err, "GetShardReplication(%v, %v, %v)", cell, keyspace, shard)
 				}
 				if !reflect.DeepEqual(fromSRi.ShardReplication, toSRi.ShardReplication) {

diff --git a/go/vt/topo/helpers/copy.go b/go/vt/topo/helpers/copy.go
@@ -177,6 +177,7 @@ func CopyShardReplications(ctx context.Context, fromTS, toTS *topo.Server) error
 			for _, cell := range cells {
 				sri, err := fromTS.GetShardReplication(ctx, cell, keyspace, shard)
 				if err != nil {
+					log.Warningf("GetShardReplication-- CopyShardReplications failed for cell %s, keyspace %s, shard %s: %v", cell, keyspace, shard, err)
 					return fmt.Errorf("GetShardReplication(%v, %v, %v): %w", cell, keyspace, shard, err)
 				}
 

diff --git a/go/vt/topo/shard.go b/go/vt/topo/shard.go
@@ -608,6 +608,9 @@ func (ts *Server) FindAllTabletAliasesInShardByCell(ctx context.Context, keyspac
 		go func(cell string) {
 			defer wg.Done()
 			sri, err := ts.GetShardReplication(ctx, cell, keyspace, shard)
+			if err != nil {
+				log.Warningf("GetShardReplication-- FindAllTabletAliasesInShardByCell failed for cell %s, keyspace %s, shard %s: %v", cell, keyspace, shard, err)
+			}
 			switch {
 			case err == nil:
 				mutex.Lock()

diff --git a/go/vt/topo/tablet.go b/go/vt/topo/tablet.go
@@ -420,6 +420,7 @@ func Validate(ctx context.Context, ts *Server, tabletAlias *topodatapb.TabletAli
 	// Validate the entry in the shard replication nodes
 	si, err := ts.GetShardReplication(ctx, tablet.Alias.Cell, tablet.Keyspace, tablet.Shard)
 	if err != nil {
+		log.Warningf("GetShardReplication-- Validate failed for cell %s, keyspace %s, shard %s: %v", tablet.Alias.Cell, tablet.Keyspace, tablet.Shard, err)
 		return err
 	}