Merge pull request #131 from Shopify/fix-unicode-loose-vindex-memory-…

…leak Backport: vindexes: fix pooled collator buffer memory leak
Shopify · Nov 27, 2023 · ab9da01 · ab9da01
2 parents f757ff2 + 437a2a9
commit ab9da01
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/go/vt/vtgate/vindexes/unicode.go b/go/vt/vtgate/vindexes/unicode.go
@@ -33,7 +33,10 @@ import (
 
 func unicodeHash(hashFunc func([]byte) []byte, key sqltypes.Value) ([]byte, error) {
 	collator := collatorPool.Get().(*pooledCollator)
-	defer collatorPool.Put(collator)
+	defer func() {
+		collator.buf.Reset()
+		collatorPool.Put(collator)
+	}()
 
 	keyBytes, err := key.ToBytes()
 	if err != nil {