Skip to content

Commit

Permalink
Merge pull request #180 from Shopify/fix-workflows
Browse files Browse the repository at this point in the history
Run vtgate workflows on ubuntu and remove assign milestone
  • Loading branch information
shanth96 authored Jul 29, 2024
2 parents 7461f20 + f3aff0d commit 59f9a19
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 38 deletions.
30 changes: 0 additions & 30 deletions .github/workflows/assign_milestone.yml

This file was deleted.

8 changes: 4 additions & 4 deletions .github/workflows/vitess_tester_vtgate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ env:
jobs:
build:
name: Run endtoend tests on Vitess Tester (vtgate)
runs-on: gh-hosted-runners-4cores-1
runs-on: ubuntu-latest

steps:
- name: Skip CI
Expand Down Expand Up @@ -110,7 +110,7 @@ jobs:
# install JUnit report formatter
go install github.com/vitessio/go-junit-report@HEAD
# install vitess tester
go install github.com/vitessio/vitess-tester@eb953122baba163ed8ccaa6642458ee984f5d7e4
Expand Down Expand Up @@ -139,12 +139,12 @@ jobs:
set -exo pipefail
i=1
for dir in ./go/test/endtoend/vtgate/vitess_tester/*/; do
for dir in ./go/test/endtoend/vtgate/vitess_tester/*/; do
# We go over all the directories in the given path.
# If there is a vschema file there, we use it, otherwise we let vitess-tester autogenerate it.
if [ -f $dir/vschema.json ]; then
vitess-tester --sharded --xunit --test-dir $dir --vschema "$dir"vschema.json
else
else
vitess-tester --sharded --xunit --test-dir $dir
fi
# Number the reports by changing their file names.
Expand Down
8 changes: 4 additions & 4 deletions test/templates/cluster_vitess_tester.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ env:
jobs:
build:
name: Run endtoend tests on {{.Name}}
runs-on: gh-hosted-runners-4cores-1
runs-on: ubuntu-latest

steps:
- name: Skip CI
Expand Down Expand Up @@ -108,7 +108,7 @@ jobs:

# install JUnit report formatter
go install github.com/vitessio/go-junit-report@HEAD

# install vitess tester
go install github.com/vitessio/vitess-tester@eb953122baba163ed8ccaa6642458ee984f5d7e4

Expand Down Expand Up @@ -137,12 +137,12 @@ jobs:
set -exo pipefail

i=1
for dir in {{.Path}}/*/; do
for dir in {{.Path}}/*/; do
# We go over all the directories in the given path.
# If there is a vschema file there, we use it, otherwise we let vitess-tester autogenerate it.
if [ -f $dir/vschema.json ]; then
vitess-tester --sharded --xunit --test-dir $dir --vschema "$dir"vschema.json
else
else
vitess-tester --sharded --xunit --test-dir $dir
fi
# Number the reports by changing their file names.
Expand Down

0 comments on commit 59f9a19

Please sign in to comment.