vindexes: fix pooled collator buffer memory leak

Signed-off-by: Brendan Dougherty <[email protected]>
Shopify · Nov 27, 2023 · 05d4ea5 · 05d4ea5
1 parent 2ebfdb0
commit 05d4ea5
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/go/vt/vtgate/vindexes/unicode.go b/go/vt/vtgate/vindexes/unicode.go
@@ -33,7 +33,10 @@ import (
 
 func unicodeHash(hashFunc func([]byte) []byte, key sqltypes.Value) ([]byte, error) {
 	collator := collatorPool.Get().(*pooledCollator)
-	defer collatorPool.Put(collator)
+	defer func() {
+		collator.buf.Reset()
+		collatorPool.Put(collator)
+	}()
 
 	keyBytes, err := key.ToBytes()
 	if err != nil {