Set CurrentTenant to nil when gem is present #1898
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This makes sure the
CurrentTenant
is set tonil
if gem is present wheneverShopifyApp
ends the request in a before action, which happens:id_token
or if it's invalid when using token exchangeReviewer's guide to testing
Steps to reproduce the error:
write_products
scope andshopify app deploy
new_embedded_auth_strategy
isfalse
HomeController#index
,ProductsController#count
andProductsController#create
bundle
and start the servershops
tablePopulate 5 products
Seeing the fix
shopify_app
in the Gemfile to this branch withgem "shopify_app", github: "Shopify/shopify_app", ref: "fix_current_tenant_error"
bundle
and restart the servershops
tablePopulate 5 products
Things to focus on
I couldn't find a nicer way to test the path of
defined?(ClassName)
, I'd appreciate if anyone has better suggestions.Anything else I'm missing?
Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.md
if the changes would impact usersREADME.md
, if appropriate./docs
, if necessary