Fix redirects for snippets #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgmanzella
force-pushed
the
fix-redirect-snippet
branch
from
14cc1d1 to
ee5f504
Compare
siakaramalegos
approved these changes
Jun 6, 2024
krzksz
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request address?
Fixes #142
What is the solution
Add clause for formatting urls for snippets
What should the reviewer focus on and are there any special considerations?
Are there other scenarios for snippets i should test??
I was able to get redirects to work for dawn, would like other apps/themes to test out 🙏
How to test
Pretty extensive steps to test, so this is optional but if you're interested see here