Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profiling for stores with custom domains #136

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Fix profiling for stores with custom domains #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/devtools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ function clear() {
function getInspectedWindowURL(): Promise<URL> {
return new Promise(resolve => {
chrome.devtools.inspectedWindow.eval(
`(/myshopify\\.io/.test(document.location.host) ? document.location.host : Shopify.shop) + document.location.pathname + document.location.search`,
`document.location.host + document.location.pathname + document.location.search`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was this code supposed to do, originally?

I think the old version is actually broken:
image

So it would have consistently used Shopify.shop to build the URL.

The fix makes sense to me, because it's simpler and will work in more cases. I'm mostly curious if anything is accidentally relying on Shopify.shop.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it comes from here. However, my understanding is that document.location.host should handle both cases (localhost and non-localhost).

function(currentUrl: string) {
resolve(new URL(`https://${currentUrl}`));
},
Expand Down