Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output url to code snippet missing file extension - resolves to a 404 in the code editor #142

Closed
verdant-spark opened this issue Apr 22, 2024 · 1 comment · Fixed by #143
Assignees

Comments

@verdant-spark
Copy link

verdant-spark commented Apr 22, 2024

Problem

When a storefront has been profiled, links offered in the 'code snippet' section are missing the extension of the file, and so this resolves to a 404 in the code editor.

For example, on one store I get the url to a snippet to be:
https://mystoredomain.com/admin/themes/135002751133?key=sections/main-product&line=542

Which results in the code editor message that: "sections/main-product does not exist"; the url should be:
https://mystoredomain.com/admin/themes/135002751133?key=sections/main-product.liquid&line=542

Which does resolve to the line for quick inspection.

Update

Looks like

function formatLiquidProfileData(
only appends the liquid file extension for the first child section of a template in the flame chart - everything below that level has the extension stripped.

@mgmanzella
Copy link
Contributor

mgmanzella commented Jun 6, 2024

👋 the fix for this issue will be in version 2.0.6 of the extension, we just submitted it for review so give it at least a week for it to appear (could take up to a few weeks). thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants