Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Commit

Permalink
Merge pull request #1929 from Shopify/extension-id
Browse files Browse the repository at this point in the history
Rename registration-id to extension-id
  • Loading branch information
pepicrft authored Jan 17, 2022
2 parents b10ce18 + 33655b2 commit ffc738c
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ From version 2.6.0, the sections in this file adhere to the [keep a changelog](h
* [#1877](https://github.com/Shopify/shopify-cli/pull/1877): Add theme (`-t`/`--theme=NAME_OR_ID`) parameter to `theme push`/`theme pull` commands
* [#1871](https://github.com/Shopify/shopify-cli/pull/1871): Add a new `--live-reload` parameter to the `theme serve` command

### Changed
- [#1929](https://github.com/Shopify/shopify-cli/pull/1929): Rename `--registration-id` to `--extension-id` in `shopify extension push`.

## Version 2.8.0
### Fixed
* [#1879](https://github.com/Shopify/shopify-cli/pull/1879): Disambiguate -s as store option
Expand Down
2 changes: 1 addition & 1 deletion lib/project_types/extension/commands/push.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class Push < ShopifyCLI::Command::SubCommand
options do |parser, flags|
parser.on("--api-key=API_KEY") { |api_key| flags[:api_key] = api_key.gsub('"', "") }
parser.on("--api-secret=API_SECRET") { |api_secret| flags[:api_secret] = api_secret.gsub('"', "") }
parser.on("--registration-id=REGISTRATION_ID") do |registration_id|
parser.on("--extension-id=EXTENSION_ID") do |registration_id|
flags[:registration_id] = registration_id.gsub('"', "")
end
end
Expand Down
2 changes: 1 addition & 1 deletion lib/project_types/extension/messages/messages.rb
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ module Messages
Usage: {{command:%s extension push}}
Options:
{{command:--api-key=API_KEY}} Connect your extension and app by inserting your app's API key (which you can get from your app setup page on shopify.dev).
{{command:--registration-id=REGISTRATION_ID}} The id of the extension's registration.
{{command:--extension-id=EXTENSION_ID}} The id of the extension's registration.
HELP
frame_title: "Pushing your extension to Shopify",
waiting_text: "Pushing code to Shopify…",
Expand Down

0 comments on commit ffc738c

Please sign in to comment.