Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename decodeSessionToken to decodeIdToken #1576

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

jplhomer
Copy link

WHY are these changes introduced?

RE: https://github.com/Shopify/app-ui/issues/1619

We're renaming sessionToken to idToken everywhere.

As part of this, we want to rename decodeSessionToken to decodeIdToken in the @shopify/shopify-api package.

WHAT is this pull request doing?

  • Our strategy is to provide a new future flag decodeIdToken which opts into removing the decodeSessionId function.
  • The new decodeIdToken function is available immediately
  • Consumers can opt-in to the new behavior where the old function is gone
  • This will become the default at our next major version.

Type of change

  • Minor: New feature (non-breaking change which adds functionality)

Checklist

  • I have used pnpm changeset to create a draft changelog entry (do NOT update the CHANGELOG.md files manually)
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

@jplhomer jplhomer changed the title Jl api id token Rename decodeSessionToken to decodeIdToken Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant