Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: pkg import only once #574

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: pkg import only once #574

wants to merge 1 commit into from

Conversation

testwill
Copy link

Description

Fixes # (issue)

Type of change
  • Bug fix 🐛
  • New feature ✨
  • This change requires a documentation update 📖
  • Breaking changes ⚠️
How Has This Been Tested?
  • Test A
  • Test B
Checklist:
  • I have 🎩 my changes (A 🎩 specifically includes pulling down changes, setting them up, and manually testing the changed features and potential side effects to make sure nothing is broken)
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The test coverage did not decrease
  • I have signed the appropriate Contributor License Agreement

dani-santos-code
dani-santos-code reviewed Nov 27, 2023
View reviewed changes
example_test.go
@@ -222,5 +221,5 @@ func Example_printOptions() {
report.PrintResults(kubeaudit.WithMinSeverity(kubeaudit.Error))

// Print results as JSON
report.PrintResults(kubeaudit.WithFormatter(&logrus.JSONFormatter{}))
report.PrintResults(kubeaudit.WithFormatter(&log.JSONFormatter{}))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

dani-santos-code
dani-santos-code approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@dani-santos-code dani-santos-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey! thanks for your contribution. Would you mind adding a little description in the PR and also signing the CLA?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dani-santos-code dani-santos-code dani-santos-code approved these changes

Assignees
No one assigned
Labels
cla-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@testwill @dani-santos-code