Update Aside in skeleton template to be more accessible #2639
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The current
Aside
component will read 'times' (or even nothing) instead of 'close' when screen readers navigate to the close button.While there are other accessibility issues with this template component, this is a quick win and it would be good for developers to get a head start with accessibility where possible.
WHAT is this pull request doing?
Adds
aria-label
to advise thebutton
element of a custom label that's different to the element's content.HOW to test your changes?
Set up the skeleton template to output locally, observe the close button in any Aside (such as the search dialog).
Before
Reminder: Some screen readers will not read anything for the 'times' symbol, but if they do they can read out things like 'multiply'.
After
Checklist
References