Update Aside in skeleton template to be more accessible (#2639)

* Update Aside in skeleton template to be more accessible * Add changeset * Update .changeset/nervous-olives-nail.md --------- Co-authored-by: Helen Lin <[email protected]>
Shopify · Nov 26, 2024 · 9979415 · 9979415
1 parent 1a4d4da
commit 9979415
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/nervous-olives-nail.md b/.changeset/nervous-olives-nail.md
@@ -0,0 +1,5 @@
+---
+'skeleton': patch
+---
+
+Update `Aside` to have an accessible close button label
diff --git a/templates/skeleton/app/components/Aside.tsx b/templates/skeleton/app/components/Aside.tsx
@@ -62,7 +62,7 @@ export function Aside({
       <aside>
         <header>
           <h3>{heading}</h3>
-          <button className="close reset" onClick={close}>
+          <button className="close reset" onClick={close} aria-label="Close">
             &times;
           </button>
         </header>