Fix flaky data_iterator_test.go by adding locking #377
+9
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
fatal error: concurrent map read and map write
that can occur when listeners are called concurrentlyExample stacktrace:
https://github.com/Shopify/ghostferry/actions/runs/12238239633/job/34135851396
https://github.com/Shopify/ghostferry/actions/runs/12239693187/job/34140746321