FXSD 300 #3042
Closed
FXSD 300 #3042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow for an admin in the theme editor to simulate a guest customer, logged in customer, and logged in admin
Committed from shop: Inventables, Inc.
Committed from shop: Inventables, Inc.
Committed from shop: Inventables, Inc.
This applies the change from inventables/easel#10069 to set the cookie banner cookie's `path` to allow it to be read from any paths on our domain—by default cookies are scoped to the beginning part of the path of the page where they're set (e.g. `/products` when set from a product page). Also sets `max-age` to 365 days so that the cookie outlasts the session.
Committed from shop: Inventables, Inc.
Committed from shop: Inventables, Inc.
Committed from shop: Inventables, Inc.
Committed from shop: Inventables, Inc.
Committed from shop: Inventables, Inc.
Committed from shop: Inventables, Inc.
Committed from shop: Inventables, Inc.
Fix propagation of cookie banner between pages
Committed from shop: Inventables, Inc.
Committed from shop: Inventables, Inc.
Committed from shop: Inventables, Inc.
Committed from shop: Inventables, Inc.
Committed from shop: Inventables, Inc.
Committed from shop: Inventables, Inc.
Committed from shop: Inventables, Inc.
Committed from shop: Inventables, Inc.
Committed from shop: Inventables, Inc.
Committed from shop: Inventables, Inc.
Committed from shop: Inventables, Inc.
Committed from shop: Inventables, Inc.
![translation-platform[bot]](https://avatars.githubusercontent.com/in/7649?s=60&v=4){kind=small}
| @@ -164,7 +164,7 @@ | |||
| "settings": { | |||
| "type_header_font": { | |||
| "label": "Font", | |||
| "info": "Selecting a different font can affect the speed of your store. [Learn more about system fonts.](https://help.shopify.com/manual/online-store/os/store-speed/improving-speed#fonts)" | |||
| "info": "Selecting a different font can affect the speed of your store. [Learn more about system fonts.](https:\/\/help.shopify.com\/manual\/online-store\/os\/store-speed\/improving-speed#fonts)" | |||
There was a problem hiding this comment.
Localization quality issues found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Videofor keysections.video.settings.video.labelis very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible. - The value
Shopify-hosted videofor keysections.video.settings.header__1.contentis very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible. - The value
Stylefor keysections.video.settings.header__3.contentis very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
This PR will fix some CSS issues / increase the SEO and change Copy
Link to Preview