Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to multiple tags to 'liquid' tag to remove theme check error #3022

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

taksh108
Copy link

PR Summary:

Remove theme check error caused by consecutive tags on 'main-product.liquid' and 'featured-product.liquid'. Included liquid tag in to rectify

Why are these changes introduced?

To Remove theme check errors, and follow recommended practices for liquid.

What approach did you take?

Other considerations

Decision log

Visual impact on existing themes

No effect on the front-end

Testing steps/scenarios

  • Step 1 > Try and change different settings for "Share" block for Product section

Checklist

@taksh108
Copy link
Author

I have signed the CLA!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant