Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Themes] Replace legacy flag in Push command #4677

Merged
merged 2 commits into from
Oct 18, 2024
Merged

[Themes] Replace legacy flag in Push command #4677

merged 2 commits into from
Oct 18, 2024

Conversation

jamesmengo
Copy link
Contributor

@jamesmengo jamesmengo commented Oct 17, 2024

WHY are these changes introduced?

https://github.com/Shopify/develop-advanced-edits/issues/374

WHAT is this pull request doing?

  1. Remove password flag as entrypoint to Legacy implementaiton
    2)legacy renders a warning and direct users to open an issue
  2. Introduces a fallback legacy altnerative

How to test your changes?

  1. Run the command with the legacy flag
  • Should render a warning and run the TS implementation
  1. Run the command with a password provided from the theme access app
  • Should run the TS implementation
  1. Run the command with legacy-3.66
  • Should run the Ruby implementaiton

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

cc: @Shopify/advanced-edits

@jamesmengo jamesmengo requested review from a team as code owners October 17, 2024 19:42
@jamesmengo jamesmengo self-assigned this Oct 17, 2024
@jamesmengo jamesmengo added the #gsd:40767 Fortify local development experience for Liquid themes label Oct 17, 2024
Copy link
Contributor

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 72.62% 8369/11525
🟡 Branches 69.13% 4114/5951
🟡 Functions 71.94% 2190/3044
🟡 Lines 72.92% 7912/10850

Test suite run success

1904 tests passing in 865 suites.

Report generated by 🧪jest coverage report action from 07468e1

Base automatically changed from revert-4559-jm/remove-ruby/push to main October 17, 2024 21:22
Copy link
Contributor

@karreiro karreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR, @jamesmengo! LGTM and works as expected for both legacy variations (with and without the --password flag) 🎩

@jamesmengo jamesmengo added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit d21729b Oct 18, 2024
36 checks passed
@jamesmengo jamesmengo deleted the jm/push-flag branch October 18, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#gsd:40767 Fortify local development experience for Liquid themes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants