Defer remote app creation during app init to include all default creation options.
#4668
+85
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success1904 tests passing in 865 suites. Report generated by 🧪jest coverage report action from 2c6fbd4 |
|
/snapit |
|
🫰✨ Thanks @isaacroldan! Your snapshot has been published to npm. Test the snapshot by intalling your package globally: pnpm i -g @shopify/[email protected]
|
|
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. |
shauns
approved these changes
Oct 17, 2024
| }) | ||
|
|
||
| return {app} | ||
| } | ||
| } | ||
|
|
||
| export type SelectAppOrNewAppNameResult = |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
With the changes to force a
linkafterapp init, we forgot to include the default creation options during app creation. Meaning that the app creation needs to happen after the cloning to have all the necessary context.WHAT is this pull request doing?
How to test your changes?
With the snapshot, just try
shopify app init, try being logged out and with different templates (check that the toml is correctly filled)Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist