Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --nodelete behaviour on dev command #4662

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Fix bug when using --nodelete flag on dev command

e97fb51
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

Fix --nodelete behaviour on dev command #4662

Fix bug when using --nodelete flag on dev command
e97fb51
Select commit
Loading
Failed to load commit list.
GitHub Actions / ESLint Report Analysis succeeded Oct 18, 2024 in 1s

ESLint Report Analysis

0 ESLint error(s) and 10 ESLint warning(s) found in pull request changed files.

Details

Annotations

Check warning on line 75 in packages/theme/src/cli/services/dev.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/theme/src/cli/services/dev.ts#L75

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 82 in packages/theme/src/cli/services/dev.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/theme/src/cli/services/dev.ts#L82

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 123 in packages/theme/src/cli/services/dev.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/theme/src/cli/services/dev.ts#L123

[@typescript-eslint/use-unknown-in-catch-callback-variable] Prefer the safe `: unknown` for a catch callback variable.

Check warning on line 103 in packages/theme/src/cli/utilities/theme-fs.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/theme/src/cli/utilities/theme-fs.ts#L103

[@typescript-eslint/no-confusing-void-expression] Returning a void expression from a function is forbidden. Please move it before the `return` statement.

Check warning on line 105 in packages/theme/src/cli/utilities/theme-fs.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/theme/src/cli/utilities/theme-fs.ts#L105

[@typescript-eslint/no-confusing-void-expression] Returning a void expression from a function is forbidden. Please move it before the `return` statement.

Check warning on line 108 in packages/theme/src/cli/utilities/theme-fs.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/theme/src/cli/utilities/theme-fs.ts#L108

[@typescript-eslint/use-unknown-in-catch-callback-variable] Prefer the safe `: unknown` for a catch callback variable.

Check warning on line 136 in packages/theme/src/cli/utilities/theme-fs.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/theme/src/cli/utilities/theme-fs.ts#L136

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 136 in packages/theme/src/cli/utilities/theme-fs.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/theme/src/cli/utilities/theme-fs.ts#L136

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 158 in packages/theme/src/cli/utilities/theme-fs.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/theme/src/cli/utilities/theme-fs.ts#L158

[@typescript-eslint/use-unknown-in-catch-callback-variable] Prefer the safe `: unknown` for a catch callback variable.

Check warning on line 200 in packages/theme/src/cli/utilities/theme-fs.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/theme/src/cli/utilities/theme-fs.ts#L200

[@typescript-eslint/use-unknown-in-catch-callback-variable] Prefer the safe `: unknown` for a catch callback variable.