Fix the issue that prevents password-protected storefronts with an ampersand &
from logging in
#4657
+64
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #4597 and improves the password prompt message (used in
shopify theme console
/shopify theme dev
/shopify app dev
) to clarify which password the prompt refers to.WHAT is this pull request doing?
This PR fixes the issue by encoding passwords when checking if they are valid.
How to test your changes?
&
in the password.git cherry-pick 3f5c201cc7d2c23259ffcccd2e217a3ba3b94644
(this will clear your password, so you will be able to see the prompt even if your password is cached).shopify theme console
.Post-release steps
N/A
Measuring impact
How do we know this change was effective? Please choose one:
Checklist