Use app context in functions

[isaacroldan]

WHY are these changes introduced?

Start using linkedAppContext in some commands.

WHAT is this pull request doing?

• Modifies all function commands to use the generic linkedAppContext instead of ensureConnectedAppFunctionContext
• Create new type AppLinkedInterface for better DX
• Update some names and types
• Delete unnecessary tests and functions related to ensureConnectedAppFunctionContext 🚀

How to test your changes?

• Run the function commands, here are some scenarios:
  • Logged out
  • In a new app
  • With an old toml (just a toml with client_id = 2222)

Try to run the commands in those scenarios and then repeat, the second time everything should work automatically.

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
• Existing analytics will cater for this addition
• PR includes analytics changes to measure impact

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes

[github-actions]

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

[isaacroldan]

/snapit

[github-actions]

🫰✨ Thanks @isaacroldan! Your snapshot has been published to npm.

Test the snapshot by intalling your package globally:

pnpm i -g @shopify/[email protected]

After installing, validate the version by running just shopify in your terminal
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	72.66% (-0.01% 🔻)	8533/11743
🟡	Branches	69.65% (-0% 🔻)	4191/6017
🟡	Functions	71.73%	2207/3077
🟡	Lines	73% (-0.01% 🔻)	8077/11065

Show files with reduced coverage 🔻

St.❔	File	Statements	Branches	Functions	Lines
🟢	... / generate-schema.ts	95% (-1.43% 🔻)	87.5%	100%	95% (-1.43% 🔻)
🟡	... / common.ts	80% (-0.95% 🔻)	62.5%	71.43%	78.95% (-1.05% 🔻)

Test suite run success

1939 tests passing in 875 suites.

Report generated by 🧪jest coverage report action from 14c8b08

[gonzaloriestra]

What about adding a default value? And could you document it in the comment above?

[isaacroldan]

I wanted to make all options mandatory and explicit, so that each command is forced to specify how it wants to load the app, i'll add some docs to this

[gonzaloriestra]

If strict is the recommended and most common way, I'd prefer to make it default to simplify, but not a strong opinion.