Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checksum calculation to no longer minify assets before calculating #4545

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

karreiro
Copy link
Contributor

@karreiro karreiro commented Sep 30, 2024

WHY are these changes introduced?

Fixes #4537

WHAT is this pull request doing?

This PR updates the calculation of checksums to no longer minify assets before calculating the checksum.

How to test your changes?

  • Run shopify-dev theme init top-hat
  • Run cd top-hat
  • Run shopify-dev theme dev --theme-editor-sync (select Keep the local version)
  • Notice that translation files no longer keep refreshing (some initial sync does happen with template and section group files due to keys that get auto-added by the platform, but they no longer loop)

Before

After

Post-release steps

N/A

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-inner-loop

Copy link
Contributor

github-actions bot commented Sep 30, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72.63% (+0.02% 🔼)
8520/11731
🟡 Branches
69.55% (+0.03% 🔼)
4177/6006
🟡 Functions 71.61% 2205/3079
🟡 Lines
72.95% (+0.02% 🔼)
8062/11052

Test suite run success

1938 tests passing in 873 suites.

Report generated by 🧪jest coverage report action from d6c661f

Copy link
Contributor

@frandiox frandiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@karreiro karreiro added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit afb2f81 Sep 30, 2024
36 checks passed
@karreiro karreiro deleted the fix-theme-sync branch September 30, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Master Issue - Theme Dev sync loop
2 participants