Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Themes] Refactor fetchStoreThemes function to prepare for public themes API #4519

Merged
merged 5 commits into from
Sep 30, 2024
Merged

[Themes] Refactor fetchStoreThemes function to prepare for public themes API #4519

merged 5 commits into from
Sep 30, 2024

Commits on Sep 25, 2024

  1. Move theme pull logic from command layer to service layer 

    Update tests

Move + fix CLI2 tests

Remove pull command test

Remove CLI2 Invocation + Tests

Remove legacy flag

Add JSDoc to pull export

Export public pull service from themes package

Revert change to theme-command
    @jamesmengo
    jamesmengo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    8d96c63 View commit details
    Browse the repository at this point in the history

  2. Update JSDoc

    @jamesmengo
    jamesmengo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    25d9279 View commit details
    Browse the repository at this point in the history

  3. Add CLI2 invocation back to pull command 

    Re-arrange + export ThemeCommand helpers
    @jamesmengo
    jamesmengo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    3ebe5f5 View commit details
    Browse the repository at this point in the history

  4. Add publicFetchStoreThemes function

    @jamesmengo
    jamesmengo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    370b675 View commit details
    Browse the repository at this point in the history

  5. Update docs and tests

    @jamesmengo
    jamesmengo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e60b91f View commit details
    Browse the repository at this point in the history