Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Themes] Add push, pull, and fetchStoreThemes to Themes Package Public Exports #4518

Merged
merged 2 commits into from
Sep 30, 2024
Merged

[Themes] Add push, pull, and fetchStoreThemes to Themes Package Public Exports #4518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b43121f
Update exports
jamesmengo Sep 24, 2024
967447b
Improve export comment in index file
jamesmengo Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/cli/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ export {default as TunnelStartHook} from '@shopify/plugin-cloudflare/hooks/tunne
export {default as TunnelProviderHook} from '@shopify/plugin-cloudflare/hooks/provider'
export {hooks as PluginHook} from '@oclif/plugin-plugins'
export {AppSensitiveMetadataHook, AppInitHook, AppPublicMetadataHook} from '@shopify/app'
export {push, pull, fetchStoreThemes} from '@shopify/theme'

export const HydrogenInitHook = HydrogenHooks.init

Expand Down
16 changes: 5 additions & 11 deletions packages/theme/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ import Push from './cli/commands/theme/push.js'
import Rename from './cli/commands/theme/rename.js'
import Serve from './cli/commands/theme/serve.js'
import Share from './cli/commands/theme/share.js'
import {pull} from './cli/services/pull.js'
import {push} from './cli/services/push.js'
import {publicFetchStoreThemes} from './cli/utilities/theme-selector/fetch.js'

const COMMANDS = {
'theme:init': Init,
Expand All @@ -37,14 +34,6 @@ const COMMANDS = {
'theme:share': Share,
}

const PUBLIC_COMMANDS = {
pull,
push,
publicFetchStoreThemes,
}

export {PUBLIC_COMMANDS}

export default COMMANDS

/** Development server for theme extensions */
Expand All @@ -53,3 +42,8 @@ export * from './cli/utilities/theme-ext-environment/theme-ext-server.js'
/** Storefront authentication support for running the development server on password-protected stores */
export {isStorefrontPasswordProtected} from './cli/utilities/theme-environment/storefront-session.js'
export {ensureValidPassword} from './cli/utilities/theme-environment/storefront-password-prompt.js'

// Expose core utilities for developers to build and expand on the CLI
export {pull} from './cli/services/pull.js'
export {push} from './cli/services/push.js'
export {publicFetchStoreThemes as fetchStoreThemes} from './cli/utilities/theme-selector/fetch.js'
Loading