Avoid loop with static assets when users pass the --theme-editor-sync
flag
#4160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
This PR updates the checksum calculation to avoid loops when users run
shopify theme dev --theme-editor-sync
and their assets directory has JSON files.It solves a similar issue addressed by #4142. However, not only the
config/settings_schema.json
file is sanitized on the platform, butassets/*.json
as well. Thus, this PR updates the checksum calculation to reflect that.WHAT is this pull request doing?
This PR adopts the same approach adopted by #4142 to JSON
assets/*
.How to test your changes?
shopify theme dev --theme-editor-sync
assets/test.json
with this content:Post-release steps
N/A
Measuring impact
How do we know this change was effective? Please choose one:
Checklist